@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS ⚠️:
- This solution consists incorrect usage of
<h2>so it can cause severe accessibility errors due to incorrect usage of level-two headings<h2>
- Every site must want only one
h1element identifying and describing the main content of the page.
- An
h1heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- In this solution there's
<h2>element which is this<h2>Improve your...</h2>, you can preferably use<h1>instead of<h2>. Remember<h1>provides an important navigation point for users of assistive technologies so we want to use it wisely
- So we want to add a level-one heading to improve accessibility
- Example:
<h1>Improve your front-end skills by building projects</h1>
- If you have any questions or need further clarification, and feel free to reach out to me.
- If you have any questions or need further clarification, you can always check out
my submissionand/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
@gisellecole
Posted
@0xAbdulKhalid
Hello Abdul Khalid,
Thank you for taking the time to review my code and for your valuable feedback! I appreciate your suggestions regarding the usage of headings, and I completely agree with you on the importance of accessibility.
I apologize for the incorrect usage of the <h2> element in my solution. Your explanation about the significance of the <h1> element as the main content identifier makes perfect sense. I will make the necessary changes to ensure proper accessibility. Your example <h1>Improve your front-end skills by building projects</h1> is a great guideline for me to follow.
I'm glad to hear that you found my solution to be great overall. Your feedback is extremely helpful, and I appreciate your willingness to provide further clarification or assistance if needed.
Once again, thank you for your time and valuable suggestions. I will make the recommended changes to improve the accessibility of my code.
Happy coding to you too!
Best regards, Giselle Cole
@0xabdulkhaliq
Posted
@gisellecole Glad you found it helpful ! 🤠
