QR code component- with Sass

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h2> so it can cause severe accessibility errors due to incorrect usage of level-two headings <h2>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h2> element which is this <h2>Improve your...</h2>, you can preferably use <h1> instead of <h2>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Giselle Cole•50

  @gisellecolePosted over 1 year ago

  @0xAbdulKhalid

  Hello Abdul Khalid,

  Thank you for taking the time to review my code and for your valuable feedback! I appreciate your suggestions regarding the usage of headings, and I completely agree with you on the importance of accessibility.

  I apologize for the incorrect usage of the <h2> element in my solution. Your explanation about the significance of the <h1> element as the main content identifier makes perfect sense. I will make the necessary changes to ensure proper accessibility. Your example <h1>Improve your front-end skills by building projects</h1> is a great guideline for me to follow.

  I'm glad to hear that you found my solution to be great overall. Your feedback is extremely helpful, and I appreciate your willingness to provide further clarification or assistance if needed.

  Once again, thank you for your time and valuable suggestions. I will make the recommended changes to improve the accessibility of my code.

  Happy coding to you too!

  Best regards, Giselle Cole

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @gisellecole Glad you found it helpful ! 🤠

  1
• 

  Steve•1,170

  @peanutbutterjllyPosted over 1 year ago

  Your final product is just about pixel perfect! Mines are usually very noticeably off; not that I'm a guru or anything, just saying.

  Also, your markup (HTML) and style (CSS) code look nice and clean.

  Overall good job IMO. 👍

  1

  ---

  

  Giselle Cole•50

  @gisellecolePosted over 1 year ago

  @peanutbutterjlly

  Hello Steve, I really appreciate your positive feedback. It means a lot to me, especially as I'm still learning and growing. I'm always open to suggestions and willing to improve. Thank you for taking the time to review my work!

  Best regards, Giselle Cole

  0