QR Code Component with Sass

Community feedback

• 

  Andy•40

  @amathias17Posted over 2 years ago

  Hi!

  I agree with George. It's not necessary to have a media query on this challenge since the card stays the same size for both desktop and mobile views, but other than that it looks great. Keep up the good work!

  Marked as helpful

  2

  ---

  

  Said Aoussar•130

  @SaidAoussarPosted over 2 years ago

  @amathias17 Thank you so much Andy . I well remove Media Query from desktop size

  1
• 

  George Stawowczyk•210

  @Jorgus1710Posted over 2 years ago

  Excellent work!

  The only nitpick I have here is that the card thins out ever so slightly when the screen size transitions beyond 992px width. That makes the card look a little too thin in desktop views. If you could remove that thinning that would make the card look perfect!

  Marked as helpful

  2

  ---

  

  Said Aoussar•130

  @SaidAoussarPosted over 2 years ago

  @Jorgus1710 Thank you so much George, i well remove Media Query from desktop size. I put the images in Figma after calculate size i see deferent between desktop and mobile that why i make small in desktop.

  1