QR Code Component with ReactJS/Vite and TailwindCSS

Community feedback

• 

  Basant Soni•450

  @SoniBasantPosted over 1 year ago

  Hi, Mate. 🙋‍♂️

  Your project is looking good.

  As for the question of flex OR grid, I recommend -

  • Flex-box when you have components in one line either in one row or one column.

  • Grid for more than one line. You will have rows and columns which are easy to handle in grid.

  Hope this is helpful. 🙂

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by replacing the <div id="root"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1