QR CODE COMPONENT WITH HTML CSS FLEXBOX

Community feedback

• 

  Tobenna•610

  @tobezhanabiPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  So fix it by replacing the element <div class="container"> the with semantic element <main> in your index.html file to improve accessibility and organization of your page.This is known as landmark

  What is landmark ? They used to define major sections of your page instead of relying on generic elements like <div> or <span> They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  HEADINGS ⚠️:

  This solution also generated accessibility error report due to lack of level-one heading <h1> Every site must want at least one h1 element identifying and describing the main content of the page.

  An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page. So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  I hope you find it helpful ! 😄 Above all, the solution you submitted is great

  Happy coding!

  Marked as helpful

  0
• 

  Md Sohail Ali•150

  @mdsohailaliPosted over 1 year ago

  Hey you can check the preview image how text size is different and placed rightly, try to lower fontsize a little bit, and everything will be look nice and good. All the best.

  Marked as helpful

  0