@pascall-de-creator
Posted
Hi @Kristina225,
Good job with your QR code component. it is awesome :).
I have some Tips to help solve your CARD SIZE and ACCESSIBILITY ISSUES
-
Consider redesigning the component in figma or XD to get the sizes more accurate
-
Use rem units for margins instead and set the root font-size to a rounded number like 10px to make conversion easier
-
Add Main tag after body as your card element or use the role attribute and set it to main
-
Use h1 tag as the first text element in your card but use only once
you can view my project: https://www.frontendmentor.io/solutions/frontend-profile-qr-code-component-website-k6U3ZnZjn
Keep up the good work!
Marked as helpful
@Kristina225
Posted
@pascall-de-creator Thank you for the feedback. :) I will change my solution to implement all of your suggestions.
