Alberto Ledesma• 370
@ledesmx
Posted
Hi Ana 👋
Great job on your solution!
Here are some recommendations for you:
- I suggest using the
min-height
property instead ofheight
. If we setheight: 100vh;
then the body will have100vh
height no matter what. Even if the content spans more than100vh
of viewport (this will result in the component being cut off on smaller screens.) Whereas withmin-height
it will continue growing. - Lastly, there is a
margin
in your body which is adding more space in addition to the100vh
. I only suggest removing it.
Code to remove:
body {
height: calc(100vh - 1px);
margin: 1.25rem;
}
Code to add:
body {
min-height: 100vh;
}
I hope this helps a little.
Well done for the rest.
Marked as helpful
0