Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr code Component with HTML and CSS

@rakesh265

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@imranhossainemi

Posted

Nice work, but some your code section need improvment.

  1. HTML accessible improvement about content landmarks. Ensure all content is contained within a landmark region, designated with HTML5 landmark elements and/or ARIA landmark regions. Screen reader users can navigate to a section based on its HTML element or ARIA Landmark.
    • Example: <div class="qr-container"> you can use HTML5 landmark element <main> and/or ARIA landmark region role="qr-container .
  2. Layout size for image of qr code. Instead of using fix height and width, use percent base width, so image can resize itself base on device or screen width.
    • Example: .qr-image { width: 90%;}

Marked as helpful

0

@rakesh265

Posted

@imranhossainemi Thanks for the Feedback, it was beneficial. I will try to rectify my mistakes and build better designs.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord