@Alex-Archer-I
Posted
Hey!
Congrats with your first challenge! Well, first here at least, as I can see you have some exp already =) It's cool!
Here is a few tips.
- It's better to use
rem
values at least for font sizes. It's a relative values which depends on browsers font settings, so users could change them. font-optical-sizing: auto;
andfont-style: normal;
are default values so you doesn't have to specify them.- Also as the whole page share one font family, you can apply it once. For example on the container element. All content elements inherited it and you doesn't have to repeat it so much.
Hope that helps =)
By the by, I love emoji in commit messages =)
Marked as helpful
@Alex-Archer-I
Thank you so much for your feedback!
You’re right, using rem values would be more appropriate, especially for accessibility. And I agree, I did overuse the font-family declaration. 😅
I’ll update my project with these changes, as they seem very relevant. Thanks again! 🙂
PS: For the emojis in commit messages, I use the Gitmoji convention, which I find helpful for quickly understanding the type of changes made.
@Alex-Archer-I
Posted
@HLIFT
Hey, you're welcome! 😄 Your comments about github (both of them 🙂) are very cool and helpful too =)