Skip to content
Submitted 12 months ago

qr code component with html and css

Tauane Custódio•330
@tauanecustodio
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Øystein Håberg•10,710
    @Islandstone89Posted 12 months ago

    Hi, you have done a pretty good job. Here is my feedback.

    HTML:

    • The alt text also needs to say where it leads (frontendmentor.io).

    CSS:

    • Performance-wise, it's better to link fonts in the <head> of the HTML then using @import.

    • It's good practice to include a CSS Reset at the top.

    • Remove width: 100vw on <main> - it is as wide as its parent(body), which is by default the full width of the viewport.

    • height should be min-height.

    • Remove all fixed widths and heights. In general, you very rarely want to set fixed dimensions.

    • Add a max-width of 20rem on the card.

    • Add display: block and max-width: 100% on the image.

    • Remove the media query - we don't want the design to change, so there is no need for one.

    Marked as helpful
    0
    Tauane Custódio•330
    @tauanecustodioPosted 12 months ago

    @Islandstone89 Your comment helped me a lot, thank you very much for that!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord