QR Code Component with HTML and CSS

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge

  Keep up the good work

  Your solution looks great however I think that the card is missing a subtle box-shadow using box-shadow.

  I hope this helps

  Cheers

  Happy coding 👍

  Marked as helpful

  1

  ---

  

  Melvin•270

  @MelvinMelonGitPosted over 2 years ago

  Hi @TheCoderGuru ,

  Oh yes! now you have mentioned it I forgot to add that. Thanks for your comment! :)

  0
• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can follow these steps:

  ✅ Disallow @import . CSS font @import prevents parallel downloads, use <link> instead.

  @import url('https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap');
  
  

  ✅ pay attention to the automatic report on your solution. you need to fix html and a11y errors

  ✅ You should use css variables. They can be useful for reducing repetition in CSS, and also for powerful runtime effects

  ✅ Missing unique Alt Text

      <img src="./images/image-qr-code.png" class="card__img">
  
  

  I hope my comment was helpful to you. If so, you can mark it useful =) It's not difficult for you, but I'm happy.

  Cheers

  Marked as helpful

  1

  ---

  

  Melvin•270

  @MelvinMelonGitPosted over 2 years ago

  Hi @isprutfromua ,

  Thanks for your detailed comments! Will improve on it for future projects! :)

  0