Skip to content
Submitted over 1 year ago

QR code component with HTML and CSS

Ali-Tofiqi•70
@Ali-Tofiqi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

do you have any idea about the Responsive of this code? if yes please send it to me.

if you know a better structure for HTML please send it to me.

Community feedback

  • _nehal💎•6,710
    @NehalSahu8055Posted over 1 year ago

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    ➨Remove margins from .card as this will not dynamically center the card.

    ➨ You are already using flex just add min-height:100vh to your body and see the effect.

    body{
min-height: 100vh;
}

    ➨ Use Semantics for the proper design of your code.

    <body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
wrap up `.attribution` inside `footer`
</body>

    • Every site must have one h1 element describing the main content of the page.

    • So, Add a level-one heading instead of h3 to improve accessibility.

    • For non-decorative images give meaningful and descriptive alt like alt= "QR code to Frontend Mentor website".

    • Don't use <b> for bolding the heading use font-weight.

    • Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

    link.

    I hope you find this helpful.

    Happy coding😄

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord