@NehalSahu8055
Posted
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
-
Remove
margins
and addmin-height:100vh
to your.qr-container
to dynamically center the card. -
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one heading
-
<h1>Improve you frontend skills by building projects</h1>
-
Use
Semantics
for the proper design of your code.
<body>
<main>... main content goes here ...</main>
<footer>... .attribution div goes here ... </footer>
</body>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding😄
Marked as helpful
@lspacka
Posted
@NehalSahu8055
Hey thanks for your help! good pointers on semantic html, I often overlook its importance.