QR code component with Flexbox

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello @NeuralG!

  Your solution looks great!

  I have a suggestion for improvement:

  • For semantic reasons, use main to wrap the main content instead of a div.

  This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1
• 

  Araf Aslam Afif•110

  @ArafAfifPosted 11 months ago

  Your solution looks great. But if you dont use the br tag, you use the font-size property your code will be standard.

  1

  ---

  

  Umutcan Çetin•110

  @NeuralGPosted 11 months ago

  Thanks for review, I will try that next time @ArafAfif

  0