QR Code Component with Flexbox

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Kenny, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • remove all margin from card class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Kenny•40

  @PomPoko-labPosted almost 3 years ago

  @denielden Hey Deniel, thanks for the tips. I'll definitely implement it asap and use it for future projects! :)

  edit: I went ahead and added the flexbox integrations as you recommended and it furthered my knowledge in flexbox. Thank you.

  1
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great work overall man.

  • To fix your accessibility issues wrap your card in a main element.

  Marked as helpful

  1

  ---

  

  Kenny•40

  @PomPoko-labPosted almost 3 years ago

  @Phalcin Hey Emmanuel, thanks for your tip. I'll definitely implement and use it for future projects! :)

  0