Qr code component with flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  CSS 🎨:

  • In this challenge, there's no need to use a media query; you can remove it. Additionally, as a side note, the values 375px and 1440px are just references indicating the dimensions of the challenge's screenshots. You don't need to incorporate them into the media query.

  • Use font-size in rem or em units rather than pixels for better responsiveness Resource.

  • You should use the box-sizing: border-box property to make the width and height properties include the padding and border of the element. This will make it easier to calculate the size of an element. You can read more about this here 📘.

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Asumpta-1•30

  @Asumpta-1Posted 11 months ago

  @MelvinAguilar Thank you Melvin for such a detailed response. I'll make the changes and also read up on the resources. Much appreciated))

  0
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 11 months ago

  Hello @Asumpta-1!

  Your project looks excelent!

  If you add a box-shadow to your card, it'll look exactly as the original design.

  Other than that, you did a great job!

  Marked as helpful

  0

  ---

  

  Asumpta-1•30

  @Asumpta-1Posted 11 months ago

  Hi @danielmrz-dev , Thanks) I'll add that too. Happy coding!

  0