QR Code Component with Flexbox and Responsive for Mobile

Community feedback

• 

  Kanishka Priyashantha•690

  @kanishkasubashPosted about 1 year ago

  Hi, Rohmat👋. Congratulations on successfully completing the challenge! 🎉

  Your solution looks grate, and you've done a fantastic job overall! However, here are some small suggestions that might interest you:

  HTML:

  • The <main> element should wrap around the entire component. Using the <header>, <main>, <footer> elements provide structural clarity, accessibility improvements, SEO benefits, and facilitates responsive design. It helps you create well-organized, maintainable, and user-friendly web pages.

  CSS:

  • If you want to build the most-accessible product possible, you need to use both pixels and ems/rems. It's not an either/or situation. There are circumstances where rems are more accessible, and other circumstances where pixels are more accessible. Link

  I hope you find this helpful! 😄 Keep up the great work! 👍

  🖥️Happy coding!

  Marked as helpful

  1

  ---

  

  Rohmat Setiawan•60

  @rohmatsetiawanmtaPosted about 1 year ago

  @kanishkasubash Thank you for your comprehensive feedback. Your advice will guide me in addressing next challenges. Thank you again!

  0
• 

  Dawid "makaroni" Markieton•140

  @greenMakaroniPosted about 1 year ago

  I think the only thing that's missing to make it pixel perfect is to increase the letter-spacing in the paragraph.

  Excellent job.

  Marked as helpful

  1

  ---

  

  Rohmat Setiawan•60

  @rohmatsetiawanmtaPosted about 1 year ago

  @greenMakaroni Yes, I found that the letter spacing in the paragraph is missing. Thank you for your feedback!

  0