Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component with Flexbox and Responsive for Mobile

@rohmatsetiawanmta

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please let me know how I can enhance this code. Kindly consider the following key points:

  • Is it accessible?
  • Is it responsive?
  • Is the code organized and easy to read?
  • Does the layout appear appealing?"

Community feedback

@kanishkasubash

Posted

Hi, Rohmat👋. Congratulations on successfully completing the challenge! 🎉

Your solution looks grate, and you've done a fantastic job overall! However, here are some small suggestions that might interest you:

HTML:

  • The <main> element should wrap around the entire component. Using the <header>, <main>, <footer> elements provide structural clarity, accessibility improvements, SEO benefits, and facilitates responsive design. It helps you create well-organized, maintainable, and user-friendly web pages.

CSS:

  • If you want to build the most-accessible product possible, you need to use both pixels and ems/rems. It's not an either/or situation. There are circumstances where rems are more accessible, and other circumstances where pixels are more accessible. Link

I hope you find this helpful! 😄 Keep up the great work! 👍

🖥️Happy coding!

Marked as helpful

1

@rohmatsetiawanmta

Posted

@kanishkasubash Thank you for your comprehensive feedback. Your advice will guide me in addressing next challenges. Thank you again!

0

@greenMakaroni

Posted

I think the only thing that's missing to make it pixel perfect is to increase the letter-spacing in the paragraph.

Excellent job.

Marked as helpful

1

@rohmatsetiawanmta

Posted

@greenMakaroni Yes, I found that the letter spacing in the paragraph is missing. Thank you for your feedback!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord