QR code component with Flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  Alt text 📷:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  2

  ---

  

  Mounir Dekali•60

  @starman1999Posted almost 2 years ago

  @MelvinAguilar Thanks a bunch for taking the time to review the project, it means a lot to me. I just checked the article and learned a lot. I actually underestimated Html a little, as an experienced developer in this field, could you please suggest a solid course that covers all the necessary Html notions? thanks

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="card-container"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Give the img a max-width of 100% for a responsive image.

  Give .card-text a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  1

  ---

  

  Mounir Dekali•60

  @starman1999Posted almost 2 years ago

  @Hassiai thank you so much, but I still don't understand certain stuff:

  • max-width property seems not to change anything about the responsiveness, is it somehow inheritable from the card-container or something?
  • the margin value for all sides for .card-text seem redundant? because I already specified *{margin:0} in the css reset file. thanks again for your valuable time.

  0