Submitted 2 months ago

QR Code component with Flex

tobytietphoto• 50

@tobytietphoto

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I was just proud that I finished the challenge and would definitely apply what I learned onto the next challenge.

What challenges did you encounter, and how did you overcome them?

I wasn't able to center my div element that contained the image and text. I used the border attribute in CSS and saw that the body element wasn't using the full height. Once, I specified 100vh. I was able to center the div element properly.

What specific areas of your project would you like help with?

I would love feedback on what I could improve on my coding presentation and any better method that could have been applied.

Community feedback

Dylan de Bruijn• 3,190

@DylandeBruijn

Posted 2 months ago

@tobytietphoto

Hiya! 👋

Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

Things you could improve ✍️

I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.
You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.
Try using semantic HTML elements like main, section and article.

I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

Happy coding! 😎

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord