Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component with CUBE CSS

Deivisson Lisboaβ€’ 190

@DeivissonLisboa

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

This is a pretty old solution. I should rewrite this to practice again my CSS skills. Make it more readable and scalable.

What challenges did you encounter, and how did you overcome them?

Getting used to CUBE CSS principles will take time.

What specific areas of your project would you like help with?

No help needed.

Community feedback

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have other suggestions about your code that might interest you.

HTML πŸ“„:

  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

Alt text πŸ“·:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. πŸ“˜.

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

1

Deivisson Lisboaβ€’ 190

@DeivissonLisboa

Posted

@MelvinAguilar Thank you for your feedback. I appreciate the time you took to share your thoughts and suggestions with me.

1
Hassia Issahβ€’ 50,670

@Hassiai

Posted

Replace<div class="car">with the main tag, <h4> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

To center .card on the page using grid, add min-height: 100vh to the body.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1

Deivisson Lisboaβ€’ 190

@DeivissonLisboa

Posted

@Hassiai Thank you for your feedback. I appreciate the time you took to share your thoughts and suggestions with me.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord