QR code component with css

Community feedback

• 

  Shalom2935•420

  @Shalom2935Posted over 1 year ago

  Good job I really like the way your code is structured.

  • Wrap all the code inside the body with a main element. By using landmarks you improve the code accessibility.
  • You don't need to give the body a max-width of 1440px, on the contrary this can become an issue for the responsive. Instead, a width: 100vw will ensure that the body will take all the width avaible on the viewport.
  • To make an image responsive, don't set its height!!! give it 100% width and give its container the width you'd want your image to have and a height set to auto.

  Hope my comments are helpful. HAPPY CODING

  0

  ---

  

  Purva Sharma•10

  @purvasharmadevPosted over 1 year ago

  @Shalom2935

  Thankyou for the amazing insights!! I will definitely keep in mind for next time.

  1