Skip to content
Submitted about 2 years ago

QR Code Component with CSS Grid

Iyapo Joseph•20
@iyapojoseph
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

i found placing the card in the center difficult? i am open to correction or new ideas? im unsure of the body part and the classes? is there any way i wan make the code more accessible and easy to understand?

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hi @iyapojoseph, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code.Something I've noticed in your code is that in many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Iyapo Joseph•20
    @iyapojosephPosted about 2 years ago

    @correlucas yes it helped thanks

    0
  • Samuele•170
    @frasconi00Posted about 2 years ago

    Hi, that's a great solution!

    Welcome to the frontend mentor community.

    I gave a look at your code and I have some ideas:

    you could just use the main tag without having to add another div tag inside: img, h1 and p tags would be enough;

    it is semantically better not to use h2 tags if there are not any h1 tags;

    as for centering, a good idea is to style the body with display: flex; flex-direction:column; justify-content:space-around; align-items:center;min-height:100vh.

    Hope you find this helpful, these are just some tips from my little experience but you really did a great job! Happy coding 😊

    Marked as helpful
    0
    Iyapo Joseph•20
    @iyapojosephPosted about 2 years ago

    @frasconi00 thank you so much

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord