QR Code Component with CSS Grid and Flex

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @Toch007 👋, good job on completing this challenge! 🎉

  I like this solution for the challenge. Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further:

  To improve your solution on mobile devices:

  • Use max-width: 300px to .card selector instead of width, this will make the card container a bit responsive on mobile and set the element's maximum width to 300px.
  • Use min-height: 470px to .card selector instead of height.
  • Use margin: 0.938rem or margin: 15px in the .card selector so that it has some space when viewed on mobile devices.

  I hope those tips will help you.

  Good job, and happy coding!

  Marked as helpful

  1