QR Code Component with CSS and HTML only

Community feedback

• 

  Aecio Neto•340

  @aecio-netoPosted about 2 years ago

  Hi, Nadir. Congratulations on completing the project. It looks great!

  Here are some considerations:

  • Indentation and space in the code - a good practice is to organize your code in a more readable way. You can eliminate some empty spaces inside your html and css.

  • Semantic HTML (main, article) These are tags that will make your code better. Just replace and/or delete some divs.

  Also, it is possible to replace the h2 with an h1, since it is the only and main title of the page.

  There are shortcuts that can help you when declaring some CSS properties. Example: padding-top: 5px; and padding-bottom: 5px; can be just a shortcut: padding 5px 0px;. less code, same result.

  Anyway, the CSS is very good.

  Congratulations on the work.

  Hope this helps.

  Marked as helpful

  1

  ---

  

  Nadir Urbina•20

  @Nadir-UrbinaPosted about 2 years ago

  @aecio-neto Thanks a lot for taking the time to provide this valuable feedback, really appreciated!

  1