Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component with CSS and HTML only

@Nadir-Urbina

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


honestly this is my first time doing this, I appreciate any feedback you can give me since I am also new to the web dev world.

Community feedback

Aecio Neto 340

@aecio-neto

Posted

Hi, Nadir. Congratulations on completing the project. It looks great!

Here are some considerations:

  • Indentation and space in the code - a good practice is to organize your code in a more readable way. You can eliminate some empty spaces inside your html and css.

  • Semantic HTML (main, article) These are tags that will make your code better. Just replace and/or delete some divs.

Also, it is possible to replace the h2 with an h1, since it is the only and main title of the page.

There are shortcuts that can help you when declaring some CSS properties. Example: padding-top: 5px; and padding-bottom: 5px; can be just a shortcut: padding 5px 0px;. less code, same result.

Anyway, the CSS is very good.

Congratulations on the work.

Hope this helps.

Marked as helpful

1

@Nadir-Urbina

Posted

@aecio-neto Thanks a lot for taking the time to provide this valuable feedback, really appreciated!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord