Design comparison
SolutionDesign
Community feedback
- @romila2003Posted about 2 years ago
Hi Casey,
Welcome to the frontend mentor community and congratulations 🎉 for completing this challenge, it was a great attempt. I found some issues I want to address:
- It is best practice to wrap the main content within the
main
tag which would ensure that your content is wrapped within the correct landmarks e.g.<main class="container"></main>
- You should also wrap your footer within the
footer
tag e.g.<footer class="attribution></footer>
Overall, great attempt and wish you the best for your future projects so keep coding 👍.
0@casey-botPosted about 2 years ago@romila2003 Thank you so much for the feedback! I'll be sure to double check those in other projects.
1 - It is best practice to wrap the main content within the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord