@rayaatta
Posted
Hi Emka18, congratulations on completing this challenge 🎉. I have some suggestions for you. 1 For semantic reasons change
<div class="title">
<p>Improve your front-end skills by building projects</p>
</div>
To
<h1 class="title">
Improve your front-end skills by building projects
</h1>
The <h1>
to<h6>
tags are used to define HTML headings. <h1> defines the most important heading. <h6>
defines the least important heading. Only use one <h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>
, then use <h2>
, and so on.
2
Remove the div. attribution
from the main and change it to footer.attribution
3
In order to center your card,
Add
min-height:100vh;
To your body and remove the margin properties from
div.wrapper
.
I hope this helps.
Happy coding ✌️
Marked as helpful