QR code component with bootstap

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 9 months ago

  Hello @phonkytoast!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

  📌 Second: Use <h1> for the main title instead of <h5>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.

  • <h1> defines the most important heading.

  • <h6> defines the least important heading.

  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  phonkytoast•30

  @phonkytoastPosted 9 months ago

  @danielmrz-dev thanks for the tips bro!

  0
• 

  Yahaya Oyinkansola•100

  @KansoldevPosted 9 months ago

  Hey there @phonkytoast, your bottom left and right border radius on your image are not the same with the top left and right

  Also, you don't need to do so much styling, as the browser is responsive for mobile by default, so maybe you can find a better way of styling the QR component without using position absolute. Again, you should wrap your entire container inside a <main> element because it helps to add semantic meaning to your page, indicating to screen readers and web crawlers where they can find the main content of your webpage, which in this case is your .card class

  Instead of also using an <h5>, use an <h2>, you have to go from <h1> - <h6>, rather than just choosing anyone at random, using an <h2> in this case is better since it would b the second heading. This are just my 2 cents, anyone can have a better opinion

  Marked as helpful

  1

  ---

  

  phonkytoast•30

  @phonkytoastPosted 9 months ago

  @Kansoldev thank you bro. much appreciate it!

  0

  

  Yahaya Oyinkansola•100

  @KansoldevPosted 9 months ago

  @phonkytoast you are welcome. Glad i could help

  0