QR code component with basic HTML and CSS (non-responsive)

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @Decimo-10 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I like this solution for the challenge. I have some suggestions you might consider to improve your code:

  • The alternative text must not contain hyphens, underscores, or the words "image" or "photo", it must be human readable.

  • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

  • You could use a CSS Reset to remove browser built-in styles and reduce browser inconsistencies. Your body's default margin causes the vertical scrollbar to appear.

  Popular reset style sheets:

  • A modern alternative to CSS resets
  • CSS Tools: Reset CSS
  • Custom CSS Reset

  To improve your solution on mobile devices 📱:

  • Use max-width: 300px to .qr selector instead of width, this will make the container card a bit responsive on mobile and set the element's maximum width to 300px.

  • Use margin: 0.938rem or margin: 15px in the .qr selector to add some space for the container card and the screen edge on mobile devices.

  • Use align-items: center to the body to center the card horizontally.

  • Update the image selector to make responsive images:

  .qr__image {
      display: block;
      /* max-width: 300px; */
      width: 100%;
      border-radius: 10px;
  }
  

  Please don't worry if your suggestions are long, they are just details. In the end, the project is well done 👏. Hope you find those tips helpful! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  2