@Alex-Archer-I
Posted
Hi!
About margins. Specifically in this project there is not a much difference whether you are create spaces between elements with margin-top or margin-bottom (also you can use flex to create gaps if you are familiar with it). And you did right thing by making gaps on the edges with padding =)
About width. Again you are already did it right with max-width property. When the screen size became less than 360px your element will take 100% of it. You can add width if you want change those percentages.
.container {
width: 95%;
max-width: 360px;
}
Oh, and I suggest you not to use role for the main tag. It already have all necessary semantic and using role could override it. Add this attribute only in rare cases when you can't use semantic tag for some reasons.
Well, those were more confirmations than advices, but hope it could help =)
