Submitted over 1 year ago

QR Code Component

jasnoludek• 70

@jasnoludek

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

EDIT: Added margin to card component in addition to changes below.

This is an updated solution. I have made changes to the html code to include semantic html tags for <main> and <footer>. I added alt text for my img tag. I changed font sizes from the px format to responsive rem. I added :root pseudo class to determine color and typography styles. I made several layout adjustments. Finally, I added drop shadow to the card.

Community feedback

_nehal💎• 6,710

@NehalSahu8055

Posted over 1 year ago

Hello Coder 👋.

Congratulations on successfully completing the challenge! 🎉

Few suggestions regarding design.

Remove the commented line below from the body as it makes no sense to us it.

/* width: 1440px; */
/* margin: auto;*/

Replace height:100vh with min-height:100vh to properly center the card.
For non-decorative images give meaningful and descriptive alt like alt= "QR code to Frontend Mentor website".
Use Semantics for the proper design of your code.

<body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>

</body>

Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

link.

I hope you find this helpful.

Happy coding😄

Marked as helpful

jasnoludek• 70

@jasnoludek

Posted over 1 year ago

Thank you for your feedback! I'm going to work on this now. @NehalSahu8055

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord