Skip to content
Submitted over 1 year ago

QR Code Component Webpage using HTML, CSS & GRID

Eniola Adewale•50
@theeniolaade
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • _nehal💎•6,710
    @NehalSahu8055Posted over 1 year ago

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    ➨Remove width:1440px from body as this is unnecessary to add in this design.

    ➨Remove margins from .card as this will not dynamically center the card.

    ➨To properly center the container.

    • USING FLEXBOX
    body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
    • USING GRID
    body{
min-height: 100vh;
display: grid;
place-items: center;
}

    ➨ Use Semantics for the proper design of your code.

    <body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
</body>

    • Every site must have one h1 element describing the main content of the page.

    • So, Add a level-one heading instead of p to improve accessibility.

    • <h1 class="head">Improve your front-end skills by building projects</h1>

    • For non-decorative images give meaningful and descriptive alt like alt= "QR code to Frontend Mentor website".

    • Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

    link.

    I hope you find this helpful.

    Happy coding😄

    Marked as helpful
    0
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    CSS 🎨:

    • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.
    • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states
    • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.
    • For this demonstration we use css Grid to center the component.
    body {
min-height: 100vh;
display: grid;
place-items: center;
}
    • Now remove these styles, after removing you can able to see the changes
    .card {
margin: 100px auto;
}
    • Now your component has been properly centered

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    0
  • Melaku Alehegn•260
    @MelakuAlehegnPosted over 1 year ago

    congratulations @eniolaade02 for finishing your first challenge. I have a few feedbacks for you in order to keep you card responsive, you can add this css to center your card on the center of the page,

    .card {
width: 400px;
text-align: center;
position:absolute;
top:50%;
left:50%;
transform: translate(-50%, -50%);
background-color:white;
padding:13px;
}

    this will set the position of your card into the center and keep it there whenever the screen size decreases. Apart from that your design looks elegant

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord