QR code component webpage CSS and HTML

Community feedback

• 

  Džiugas Balčiūnas•190

  @DziugisLTPosted about 2 years ago

  Amazing job!

  I suggest using flexbox for centering your div and also putting it in <main> tag. Furthermore, you should use <h1> first and only then <h2>

  Everything else seems good.

  Good luck on your journey!

  1
• 

  Arthur Roberts•410

  @arfarobsPosted about 2 years ago

  Hey. Great work so far Casparas.

  I suggest wrapping your <div class="qr-code"> with a <main> element. This will improve accessibility.

  When using headings, you should always start with a <h1> and work your way down from there. If your document doesn't have a <h1> heading, then it shouldn't have a <h2> heading. I suggest replacing the <h2> with an <h1> element.

  Hope it helps.

  1
• 

  Adriano•38,040

  @AdrianoEscarabotePosted about 2 years ago

  Hello Casparas! Welcome to the Front-end Mentor community.

  Congrats on the challenge! the responsiveness was very good.

  I have some tips for you:

  1- Document should have one main landmark, you could have put all the main content inside the main tag it would make your code more semantic [check this](https://dequeuniversity.com/rules/axe/4.3/landmark-one- main?application=axeAPI)

  2- Page should contain a level-one heading click here

  3- Try to center the page content using flex-box. flex allows you to have more control over what you are doing. check this

  **But the rest is very good congratulations on the result. Congratulations 🥳 **

  1