QR code component

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 6 months ago

  Good job!

  Here is some feedback:

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • All images need an alt attribute. If it's a decorative image, make the alt text empty:alt="". This image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  CSS:

  • Including a CSS Reset at the top is good practice.

  • overflow: hidden is not needed for this project.

  • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • On body, remove the width, as it is 100% wide by default.

  • Remove the width and height on the card. We rarely want to set fixed sizes in px, as it prevents components from responding to different screens.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Likewise, font-family should be set on the body, and removed elsewhere.

  • It is common to add display: block on images so that they fill the entire height of their wrapping <div>.

  Marked as helpful

  0

  ---

  

  FITRI RASO•10

  @Fit-DeveloperPosted 6 months ago

  Thanks a lot, This is a small thing to make me be a better developer @Islandstone89

  1
• 

  Omkar•20

  @OmkarShipurkar1Posted 6 months ago

  Almost Perfect!!

  2