QR Code Component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Ashley Stone,

  Congratulation on completing this challenge. your solution looks great. I have some suggestions regarding your solution:

  • Use the <main> landmark to wrap the body content as HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.

  CSS:

  • To center the component on the middle of the page you may use the flex/grid properties with min-height 100vh; to the body.

  • width: 280px;an explicit width is not a good way. consider using max-width to the card instead.

  • height: 450pxIt's not recommended to set height to component, let the content of the component define the height.

  • Consider using rem and em as they are flexible units rather that absolute units px, specially for font size. If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  Aside these , Good work!

  Marked as helpful

  0

  ---

  

  Ashley Stone•90

  @asha12562Posted over 2 years ago

  @PhoenixDev22 Thank you for your comment, really appreciate the feedback

  1