Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
The <div class="attribution"> should be out of the <div class="card"> . Replace<div class="card">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. Add the alt attribute
alt= ""
to the img tag <img> to fix the error issue. the value for the alt is the description of the image. for more on semantic html visit https://web.dev/learn/html/semantic-html/There is no need for a class in the body tag in order to style it. To center .card on the page using flexbox add, min-height: 100vh; align-items: center: justify-content: center; to .container and remove position absolute and its properties.
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord