QR Code Component

Community feedback

• 

  

  Grace•32,170

  @grace-snowPosted 3 months ago

  This has quite a few beginner mistakes we see a lot. So rather than me repeat all the feedback for you here, I'm going to point you to some I've left on another's solution as a lot of that will be applicable: https://www.frontendmentor.io/solutions/qr-code-component-using-html-css-flex-eICDfhakO_

  You actually need less feedback than on that one, but hopefully it will still be a good learning resource for you.

  The really important things for you to grasp are why we include a modern CSS reset, why we don't set widths on elements, and how and when to write good alt text on images

  One extra point for you: Read about CSS specificity and why it's a really bad idea to nest CSS selectors and make them more specific than you need to.

  1

  ---

  

  Creative-mindset21•30

  @Creative-mindset21Posted 3 months ago

  @grace-snow Thanks for your comment. I have gone through the corrections and I have a questions

  • You made mention of putting the stlye.css in it's own file, I would like to ask why that is necessary

  0

  

  

  Grace•32,170

  @grace-snowPosted 3 months ago

  @Creative-mindset21 You already have the css in its own file.

  It's mainly a readability and scale-ability issue. As you add the css reset and as you move onto bigger projects the css will get bigger and bigger.

  0
• 

  Stéphen Chevalier•10

  @NeogiciaaPosted 3 months ago

  Hey and well done for your QR Code !

  Your design is what was attended congratulations, i would only suggest you to take care about design details that are present in project's Figma.

  See you,

  0

  ---

  

  Creative-mindset21•30

  @Creative-mindset21Posted 3 months ago

  @Neogiciaa Thanks for your comment. I will work on that

  0