Qr Code component viewer

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Ahmed, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • use h1 for the title of card not h6
  • use p tag for the text of card not small tag
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Ahmed Hassan•60

  @ah7255703Posted over 2 years ago

  @denielden

  ok iam going to change right now,i like constructive criticism thx

  1