QR Code Component

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Let me explain, How you can easily center the component for better layout without usage of absolute positioning.

  ---

  • We don't need to use absolute to center the component both horizontally & vertically. Because using absolute will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  #outsidebox {
    position: absolute;
    left: 50%;
    top: 50%;
    transform: translateX(-50%) translateY(-50%);
  }
  

  ---

  • Now your component has been properly centered.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  TreNyceCodes•230

  @TrenyceCodesPosted over 1 year ago

  When you use the root element make sure to use it. You don’t need to assign the hsl, or rgb to the property if it’s in root.

  :root {
     -background-color: -background-color: hsl(212, 45%, 89%);
  }
  
  background-color: var(-background-color); 
  

  0
• 

  eyu.•360

  @EyuleoPosted over 1 year ago

  you can center the div using display grid or flex

  body{
    min-height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
  }
  
  or 
  
  body{
     min-height: 100vh;
     display: grid;
     place-content: center;
  }
  

  hope this helps.

  0