QR Code Component

Community feedback

• 

  anass-lamiri•320

  @Anass-LamiriPosted 10 months ago

  Hello, your solution is very well defined, I only want to add a small change to make your solution more refined. in the mobile viewport when going less than 375px your main element starts touching the edges of the screen, I think you should add padding in your body so that it can never touch the edges.

  hope you find this feedback helpful.

  Marked as helpful

  1

  ---

  

  emmadumbi•260

  @emmadumbiPosted 10 months ago

  Noted, thanks @Anass-Lamiri

  1
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @emmadumbi!

  Your solution looks excelent!

  I have just one suggestion:

  📌 In order to make your HTML code more semantic, use <h1> for the main title instead of <p>. The tag <p> is meant for paragraphs. For titles though, we have the HTML headings (the tags <h1> to <h6>).

  📌 Here's a quick guide on how to use them:

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.

  • <h1> defines the most important heading.

  • <h6> defines the least important heading.

  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0