QR Code Component By WhaleWellWell

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi @WhaleWellWell 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  It's a great solution and a good start. I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <article role="main" class="card"> to improve the accessibility of the website. Even though this challenge is not a full page, you should use semantic tags and also, it is preferable to use the semantic tag instead of using role="main".

  • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

  • In my opinion, the div with the card__image_wrapper class is unnecessary.

  • Use min-height: 100vh to the body selector instead of height. This property lets you set a height and let the element grow even more if necessary.

  • On mobile devices, the "button-whale" button is large, which may make it difficult for some users to scan the QR code on cell phones.

  Please don't worry if your suggestions are long, they are just details. In the end, the project is well done 👏. Hope you find those tips helpful! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  0

  ---

  

  Whale Well Well•50

  @WhaleWellWellPosted almost 2 years ago

  @MelvinAguilar Thank You!

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  replace the <div class="card"></div> with the main tag. To center the content on a page. replace the height: 100vh in the body with min-height: 100vh; there is no need to give the body a width and height value. There is no need for display:flex and it properties in .card_image_wrapper. there is no need to give the .card_title and .card_text. margin-left and right value, you can give margin .card_title a margin bottom value instead of margin: auto; Hope am helpful Happy coding

  0