@MelvinAguilar
Posted
Hi @WhaleWellWell π, good job completing this challenge, and welcome to the Frontend Mentor Community! π
It's a great solution and a good start. I have some suggestions you might consider to improve your code:
- Use the
<main>
tag to wrap all the main content in your solution instead of using<article role="main" class="card">
to improve the accessibility of the website. Even though this challenge is not a full page, you should use semantic tags and also, it is preferable to use the semantic tag instead of usingrole="main"
.
- To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.
- In my opinion, the div with the
card__image_wrapper
class is unnecessary.
- Use
min-height: 100vh
to thebody
selector instead ofheight
. This property lets you set a height and let the element grow even more if necessary.
- On mobile devices, the "button-whale" button is large, which may make it difficult for some users to scan the QR code on cell phones.
Please don't worry if your suggestions are long, they are just details. In the end, the project is well done π. Hope you find those tips helpful! π
Good job, and happy coding! π
Marked as helpful
@WhaleWellWell
Posted
@MelvinAguilar Thank You!