@MelvinAguilar
Posted
Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.
HTML:
- The
altattribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteraltattribute would beQR code to frontendmentor.io
If you want to learn more about the alt attribute, you can read this article.
CSS:
- Instead of using pixels in font-size, use relative units like
emorrem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.
- To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here. You can read more about centering in CSS here.
body {
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
min-height: 100vh;}
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding and Happy New Year! 🎉🎊🎁
Marked as helpful
@boypaida12
Posted
@MelvinAguilar thanks for the feedback. I used the :root element to set the font size to 15px as was given in the style guide and proceeded to use rem to set the font sizes of the individual text elements. Is that a problem?
@MelvinAguilar
Posted
@boypaida12 Hi!, sorry for the delay
The biggest problem with modifying the font-size in the :root is that if the user modifies the default font size in his browser, the text of his solution will not be altered, it will remain at 15px, you can try it by searching for "change default font to my browser" in Google.
Consider that there are users with vision problems and this can be a help
Marked as helpful
