QR code component using Vanilla CSS and Flexbox

Community feedback

• 

  Ciceron•940

  @MarcusTuliusCiceronPosted over 2 years ago

  Hi, congrats on completing this challenge,

  Your code is really clean, one little remark (its really not a big deal), rem unit are not always adapted to width and height and will make design less responsive, it is better to stick to %, vh, vw, vmin or other relatives unit. rem is usually better for font size and line height.

  Hope this will help, and again this isn't really a big deal.

  Happy coding :D

  Marked as helpful

  0

  ---

  

  Mo•840

  @MohamedAridahPosted over 2 years ago

  @MarcusTuliusCiceron i really appreciate your notes and will take it in consideration in the other projects.👍😍
  So if i got you right, i should use relative units instead of rem especially with width and height, is that right?

  Have a nice day^^

  1

  

  Ciceron•940

  @MarcusTuliusCiceronPosted over 2 years ago

  @MohamedAridah yes, rem is also a "relative" unit but it's relative to user preferences. Size of other element needs to be relative to viewport size to ease the responsiveness (you still need some breakpoint to modify the display for different device)

  0