Qr Code Component using TailwindCSS

Community feedback

• 

  Doston Nabotov•950

  @dostonnabotovPosted about 2 years ago

  Hi, there! That looks great. But, I found some problems, too

  • the contrast color for your paragraphs is deficient, which means it will fail in accessibility. Also, it can barely be seen
  • you don't need to import that much stuff in your CSS. Use the KISS (Keep It Simple Stupid) strategy. Don't overcomplicate things.
  • in terms of markup, use a heading. It is better to add a heading where it should be instead of a paragraph. E.g.

  <h3>Improve your front-end skills by building projects</h3>
  

  • don't leave unnecessary comments in HTML, which makes it hard to navigate. Simply remove them if you don't need them.

  I hope it helps. Good luck!

  Marked as helpful

  0

  ---

  

  andrew•80

  @theadgPosted about 2 years ago

  @dostonnabotov Thanks for the feedback bro! I'll be submitting a new solution :))

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi @theadg, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Replace the <p> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  0

  ---

  

  andrew•80

  @theadgPosted about 2 years ago

  @correlucas Thanks for the feedback bro! Will surely take note of this.

  0