QR Code Component using basic css styling

Community feedback

• 

  Fraser Watt•1,790

  @fraserwatPosted almost 3 years ago

  This is looking really good!!

  Few changes:

  • I wouldn't explicitly set the height and width attributes on your <main> section, instead let padding, margin and the layout work itself out.
  • Likewise, on the <main> section, try seeing if you can get it to auto-position itself in the center of the screen using margins (and maybe flex)
  • And after, that, see if you can get the attribution section (which should be a <footer> element to auto-position itself at the bottom of the screen using similar techniques (although you'll want a bit of padding-bottom if you do this)

  Keep it up!! Happy coding!!

  Marked as helpful

  0

  ---

  

  Nightcode16•110

  @Nightcode16Posted almost 3 years ago

  @fraserwat Thank you, can you please show the code of what do you mean on your first and second suggestion, sorry I'm still a beginner and doesn't get what you mean but still thank you.

  0
• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Good job with this challenge. Viewing at your solution, I would suggest the following...

  • Clean the whitespaces in the code
  • Import the attribution style in the CSS file and remove style tag

  Overall you did well and Keep up it!

  Marked as helpful

  0

  ---

  

  Nightcode16•110

  @Nightcode16Posted almost 3 years ago

  @RioCantre Thank you ❤ I'll apply it next time.

  1