Design comparison
SolutionDesign
Community feedback
- @davinceeyPosted about 2 years ago
Hello Kawsar Ahmed Fahad. Congratulations on finishing this project. It's wonderful and great on the whole! Just a little tip:
You might want to se semantic tags like the
<main>
to wrap your code, instead of using divs and assigning aria roles that are not valid.You could also make use of
<section>
and/or<article>
semantic tags. This would help improve accessibility.Hope this helps you. Happy Coding!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord