QR code component using SASS

Community feedback

• 

  optimusprime202•1,200

  @optimusprime202Posted almost 3 years ago

  Hey @RenzenL, This is really nice.

  Marked as helpful

  1

  ---

  

  Renzen Lama•40

  @RenzenLPosted almost 3 years ago

  @optimusprime202 thank you !

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Renzen, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • for remove the scroolbar you can reset the margin of body:

  body {
      margin: 0;
  }
  

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  1
• 

  Renzen Lama•40

  @RenzenLPosted almost 3 years ago

  Thank you very much for your feedback. It really helps a lot. I will read more about Accessibility and the removal of scrollbar by reset of margin of body is really helpful.

  1

  ---

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @RenzenL You are welcome ! and keep it up ;)

  Marked as helpful

  1