Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component using SASS

@ShrutiShinde418

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any suggestions are welcome.

Community feedback

@shashreesamuel

Posted

Good job completing this challenge Shruti

Keep up the good work

Your solution looks great however I think that the card is missing a box-shadow using box-shadow.

Also great job using the bem naming convention however in terms of your code I would recommend the usage of div instead of section since it serves more meaning. A section tag can only be meaningful if the role attribute is mentioned to give it meaning.

Hope this helps

Cheers

0
Danilo Blas 6,300

@Sdann26

Posted

Hi ShrutiShinde418!

The truth is that you have done quite well, congratulations for finishing the challenge. I would recommend adding a slight shadow to the card, with the rgba function, which works like rgb but the last aplha value specifies the transparency, box-shadow: 0 4px 12px -4px rgba(0, 0, 0, 0, 0.2).

There really isn't much I can recommend now that you're with SASS and BEM methodology you could learn CSS architecture like that of 7 to 1.

Translated with www.DeepL.com/Translator (free version)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord