Melvin Aguilar ๐ง๐ปโ๐ปโข 61,220
@MelvinAguilar
Posted
Hi @graple-guillos ๐, good job completing this challenge, and welcome to the Frontend Mentor Community! ๐
Here are some suggestions you might consider:
- Use
min-height: 100vh
tomainContainer
selector, with this property you set a height and you let the element grow even more if necessary. Also, remove themargin: 9vh 1em;
to center correctly. - Use
align-items: center
to themainContainer
to center the card vertically. - Add descriptive text to the
alt
attribute of the images. The text must clearly describe the image. The alt attribute enables screen readers to read the information about on-page images and will be displayed instead if an image file cannot load. - You should not name your class with the camelCase convention. Use naming naming conventions to name it.
- Add an h1 tag to your solution. The
<h1>
element is the main heading on a web page. There should only be one<h1>
tag per page, and always avoid skipping heading levels; Always start from<h1>
, followed by<h2>
, and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)
Solution:
<h1>Improve your front-end skills by building projects</h1>
I hope those tips will help you.
Good job, and happy coding!
Marked as helpful
1
graple-guillosโข 40
@graple-guillos
Posted
@MelvinAguilar Man, you are a magician!! Thank you for the feedback. It was very instructive.
0