Frontend Mentor | QR code component using Sass and vite coding challenge solution

Solution retrospective

What are you most proud of, and what would you do differently next time?

I’m very happy that the finished project is very close to the template. It was my first attempt at Sass, which is a new technology for me to learn.

What challenges did you encounter, and how did you overcome them?

I had some issues with compiling SCSS files to CSS and also with GitHub not recognizing CSS files

What specific areas of your project would you like help with?

I'm not sure why I have a scrollbar appearing, even though the body height is 100vh.

Community feedback

@DylandeBruijn

Posted 2 months ago

@DeeSzubert

Hiya! 👋

Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

Things I like about your solution 🎉

Things you could improve ✍️

I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.
You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
Be careful setting a fixed width and height on elements, this will cause overflow issues when the content inside your elements grows. You can check this on smaller viewports.
You don't have to wrap your image in a div. You can style the image directly to achieve the same result.

I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

Happy coding! 😎

Marked as helpful

@DeeSzubert

Posted 2 months ago

thank you much @DylandeBruijn . very helpful comment i will try improve my code :). have a great day

QR code component using Sass and vite