Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code component using SASS

@claire-conrardy

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey everyone, I am not very sure about the media queries parts of my code, if someone could check this out and let me know what could I do to improve this? Thanks!

Community feedback

@Eric-Ferole

Posted

Good job Claire. It's close to perfect.

Here some recommendations :

  • Add a border radius to .qr-background of 10px.
  • For your QR image and background, to make things simpler, you could add the background directly to the div.qr-code and align your <img qr-code.svg> in the center of the div with flexbox.
  • Media query is not needed here because the size of the div.card in desktop resolution is the same as in mobile resolution.
  • Review your accessibility issues and make sure you understand them.

Keep up and see you around ;)

Éric F.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord