Skip to content
Submitted over 2 years ago

Qr code component using React.js and Styled Components

Mahmoud•150
@Mamouty
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I had difficulties when linking the images in the react components. I still don't understand why they have to be put in the src folder so that they would be displayed in the website after deployment. I've read somewhere that it had to do with the Webpack module, can someone explain to me more on the subject ?

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello Mahmoud, congratulations for your new solution!

    Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

    Something I've noticed in your code is that in many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, making the images easier to work, see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
    Mahmoud•150
    @MamoutyPosted about 2 years ago

    @correlucas Thank you for the remarks and information, really helpful. I was actually wondering if I could use main for a card.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord